Re: [PATCH][ANNOUNCE] Linux 2.5.68-ce2

[Jörn Engel]

On Tue, 22 April 2003 14:26:21 -0400, Chuck Ebbert wrote:
> diff -u --exclude-from=/home/me/.exclude -r a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S
> --- a/arch/i386/kernel/entry.S	Sat Mar 29 09:16:32 2003
> +++ b/arch/i386/kernel/entry.S	Sun Apr 20 14:29:01 2003
> @ -382,10 +382,11 @
>  ENTRY(interrupt)
>  .text
>  
> +	.align 16,0x90			# make ENTRY have correct address
>  vector=0
>  ENTRY(irq_entries_start)
>  .rept NR_IRQS
> -	ALIGN
> +	.align 16,0x90			# should be cacheline-aligned?
>  1:	pushl $vector-256
>  	jmp common_interrupt
>  .data
> @ -394,17 +395,18 @
>  vector=vector+1
>  .endr
>  
> -	ALIGN
> +	.align 16,0x90
>  common_interrupt:
>  	SAVE_ALL
>  	call do_IRQ
>  	jmp ret_from_intr
>  
>  #define BUILD_INTERRUPT(name, nr)	\
> +	.align 16,0x90;			\
>  ENTRY(name)				\
>  	pushl $nr-256;			\
>  	SAVE_ALL			\
> -	call smp_/**/name;	\
> +	call smp_/**/name;		\
>  	jmp ret_from_intr;
>  
>  /* The include is where all of the SMP etc. interrupts come from */

How about the following?

+#include <linux/cache.h>
+#define CACHELINE_ALIGN .align L1_CACHE_BYTES,0x90
...
-	ALIGN
+	CACHELINE_ALIGN
...

Or was this a bad guess of what you wanted to do?

Jörn

-- 
Do not stop an army on its way home.
-- Sun Tzu