Re: 2.5.67-ac2 and lilo

[Andries Brouwer]

On Sat, Apr 19, 2003 at 10:07:25AM -0700, Christian Staudenmayer wrote:

> i'm running a machine that uses the aic7xxx driver for the old adaptec 2940 scsi
> controller. i had problems with getting 2.5.67-ac2 to run, it used to end in
> a kernel panic. i got told to remove the body of the function ide_xlate_1024
> by just "return 0;", which fixed the problem, i could then boot the kernel.
> but now, when running lilo, i get the following message:
> 
> Fatal: First boot sector doesn't have a valid LILO signature
> 
> these problems do not occur on kernels 2.4.20, 2.4.21-pre7-ac1 and 2.5.67-bk9,
> if i boot another kernel, i can run/install LILO without problems.
> 
> i'd appreciate any insight on this problem.

Hmm. You did not forget to rerun LILO or so?
If ide_xlate_1024 does nothing but "return 0" then
handle_ide_mess() does nothing.

What other differences does -ac2 have?
It reintroduces a bug in the partition reading code - the fragment

@@ -456,7 +556,7 @@
                if (!subtypes[n].parse)
                        continue;
                subtypes[n].parse(state, bdev, START_SECT(p)*sector_size,
-                                               NR_SECTS(p)*sector_size, slot);
+                                               NR_SECTS(p)*sector_size, n);
        }
        put_dev_sector(sect);

of the -ac2 patch is bad.
In order to judge whether it is this or something else I would have
to know much more about your system. What are the kernel boot messages
for this disk under 2.5.67-bk9 that works and 2.5.67-ac2 that fails?
What is the partition table? No disk managers in sight? Does LILO
have lba32 or linear options?
Does 2.5.67-ac2 work if you replace its fs/partitions/msdos.c by
the vanilla one?

Andries