Re: [PATCH] drivers/net/rcpci45 DMA mapping API conversion

[Jeff Garzik]

Francois Romieu wrote:
> Re,
> 
> Jeff Garzik <[e-mail]> :
> [...]
> 
>>Ok, I finally got around to attacking this one.  Your patch looked ok to 
>>me until I noticed one detail:
>>
>>         pDpa->msgbuf = kmalloc (MSG_BUF_SIZE, GFP_DMA | GFP_KERNEL);
>>
>>The GFP_DMA tag indicates that we can't just use pci_alloc_consistent in 
>>the normal way, as we lose the GFP_DMA designator.
> 
> 
> Does it mean the usual pci_set_dma_mask() cooking or something more elaborate ?

Reading dma_alloc_coherent() in arch/i386/kernel/pci-dma.c, it does 
appear that would be sufficient...

	Jeff