[PATCH] Solved: 2.4.20, 2.5.66 have different IDE channel

Chuck Ebbert (76306.1226@compuserve.com)
Fri, 18 Apr 2003 19:33:22 -0400


2.4 builds its global PCI device list in breadth-first order.

2.5 is doing the scan that way but defers the construction of the
global list until later and then does it depth-first. This causes
devices to found in different order by drivers. The below fixed that
problem for me:

--- linux-2.5.66-ref/drivers/pci/bus.c Sat Mar 29 09:16:22 2003
+++ linux-2.5.66-uni/drivers/pci/bus.c Fri Apr 18 19:08:04 2003
@ -75,7 +75,8 @
* Add newly discovered PCI devices (which are on the bus->devices
* list) to the global PCI device list, add the sysfs and procfs
* entries. Where a bridge is found, add the discovered bus to
- * the parents list of child buses, and recurse.
+ * the parents list of child buses, and recurse (breadth-first
+ * to be compatible with 2.4)
*
* Call hotplug for each new devices.
*/
@ -98,6 +99,12 @
#endif
pci_create_sysfs_dev_files(dev);

+ }
+
+ list_for_each_entry(dev, &bus->devices, bus_list) {
+
+ BUG_ON(list_empty(&dev->global_list));
+
/*
* If there is an unattached subordinate bus, attach
* it and then scan for unattached PCI devices.

------
Chuck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/