Re: [2.5.67-mm4] Badness in local_bh_enable at kernel/softirq.c:105

[Andrew Morton]

[e-mail] wrote:
>
> 
> Seems to be triggered by network traffic on 3c574 PCMCIA ethernet card.
> Several different traces appear.
> 
> Config: Sony Vaio. Celeron 333, 128MB, 3c574 PCMCIA ethernet.
> 
> These are a few of the traces.
> 
> Badness in local_bh_enable at kernel/softirq.c:105
> Call Trace:
>  [<c0120dcd>] local_bh_enable+0x8d/0x90
>  [<c022bd10>] udp_sendmsg+0x1b0/0x880
>  [<c01195d5>] scheduler_tick+0x3a5/0x3b0
>  [<c022c9be>] udp_recvmsg+0x24e/0x2d0
>  [<c02349ad>] inet_sendmsg+0x4d/0x60
>  [<c01f319e>] sock_sendmsg+0x9e/0xd0
>  [<c0109bb8>] common_interrupt+0x18/0x20
>  [<c020822f>] __ip_route_output_key+0x2f/0xf0

Thanks, this should fix it up.

 25-akpm/drivers/net/pcmcia/3c574_cs.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff -puN drivers/net/pcmcia/3c574_cs.c~3c574-irq-fix drivers/net/pcmcia/3c574_cs.c
--- 25/drivers/net/pcmcia/3c574_cs.c~3c574-irq-fix	Fri Apr 18 16:24:21 2003
+++ 25-akpm/drivers/net/pcmcia/3c574_cs.c	Fri Apr 18 16:25:11 2003
@@ -940,11 +940,9 @@ static int el3_start_xmit(struct sk_buff
 		outw(SetTxThreshold + (1536>>2), ioaddr + EL3_CMD);
 	}
 
-	dev_kfree_skb (skb);
 	pop_tx_status(dev);
-
-	spin_unlock(&lp->window_lock);
-	
+	spin_unlock_irqrestore(&lp->window_lock, flags);
+	dev_kfree_skb(skb);
 	return 0;
 }
 

_