Re: [PATCH] devfs (1/7) - fix compilation

[Linus Torvalds]

On Fri, 18 Apr 2003, Christoph Hellwig wrote:
> @@ -1456,8 +1455,8 @@
>      dev_t devnum = 0, dev = MKDEV(major, minor);
>      struct devfs_entry *de;
>  
> -    if (flags)
> -	printk(KERN_ERR "%s called with flags != 0, please fix!\n");
> +    /* we don't accept any flags anymore.  prototype will change soon. */
> +    BUG_ON(flags);

PLEASE don't use BUG_ON() except for conditions that you really cannot 
continue from. It's damn impolite (and it makes debugging impossible) to 
kill the kernel startup if somebody has a unconverted driver or similar.

		Linus