Re: [TRIVIAL] kstrdup

Jeff Garzik (jgarzik@pobox.com)
Fri, 18 Apr 2003 04:10:17 -0400

Rusty Trivial Russell wrote:
> +char *kstrdup(const char *s, int gfp)
> +{
> + char *buf = kmalloc(strlen(s)+1, gfp);
> + if (buf)
> + strcpy(buf, s);
> + return buf;
> +}

You should save the strlen result to a temp var, and then s/strcpy/memcpy/

Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/