Re: [ANNOUNCE]: version 2.00.3 megaraid driver for 2.4.x and 2.5.67

[James Bottomley]

On Thu, 2003-04-17 at 07:38, Christoph Hellwig wrote:
> On Wed, Apr 16, 2003 at 04:34:22PM -0400, Mukker, Atul wrote:
> > New megaraid driver 2.00.3 is now available at
> > ftp://ftp.lsil.com/pub/linux-megaraid For this driver, a patch is also
> > available for 2.5.67 kernel.
[...]

I'm not inclined to force style changes in any drivers with active
maintainers on the grounds that we already have much worse offenders in
the tree (and style changes do make merging a pain).

I counted one serious issue:

The try_module_get problem

One future compatibility issue:

->detect moved to scsi_add_host (for the device model).

One issue that would improve the driver internally:

move hba_soft_state array to dynamic ->hostdata

plus a list of other more style related issues.

I'll fix up the first one, Atul, can you take the other two for a future
patch (the others Christoph mentions might be nice, too...)?

James