Re: [TRIVIAL PATCH] sync_dquots_dev in Linux 2.4.21-pre7-ac1

[Jan Kara]

> sync_dquots_dev() is only implemented if CONFIG_QUOTA is defined.
> However, quote.c uses it unconditionally.  include/linux/quotaops.h has
> some macros to disable some functions when CONFIG_QUOTA is undefined, so
> it's probably where the fix belongs.  This patch helps:
> 
> ==============================
> --- linux.orig/include/linux/quotaops.h
> +++ linux/include/linux/quotaops.h
> @@ -193,6 +193,7 @@
>  #define DQUOT_SYNC_SB(sb)			do { } while(0)
>  #define DQUOT_OFF(sb)				do { } while(0)
>  #define DQUOT_TRANSFER(inode, iattr)		(0)
> +#define sync_dquots_dev(dev, type)		do { } while(0)
>  extern __inline__ int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
>  {
>  	lock_kernel();
> ==============================
  Oops... Yes. Please apply the patch Alan.

								Thanks
									Honza

-- 
Jan Kara <[e-mail]>
SuSE CR Labs