Re: [PATCH] Re: 2.5.67: ppa driver & preempt == oops

Randy.Dunlap (rddunlap@osdl.org)
Tue, 15 Apr 2003 14:51:55 -0700


On 15 Apr 2003 17:37:56 -0400 Robert Love <rml@tech9.net> wrote:

| On Tue, 2003-04-15 at 15:00, Patrick Mansfield wrote:
|
| > We never hold the host_lock while calling the detect function (unlike the
| > io_request_lock, see the bizzare 2.4 code), so acquiring it inside
| > ppa_detect is very wrong. I don't know why your scsi scan did not hang.
|
| I do not have this device so I cannot test it, but your logic seems
| correct.
|
| This is a much nicer fix for the preempt-related issues than others
| proposed, too.
|
| Anyone out there who _can_ mount the device? Can you test this? It
| ought to be merged if it works. We need to get device drivers in 2.5 up
| to par..

I have such a device at home. I can try to test it (if the device
still works). What needs to be tested?

or maybe I can loan it to patmans for 1 day...

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/