Re: New Software Suspend Patch for testing.

[Nigel Cunningham]

Hi.

On Wed, 2003-04-16 at 08:06, Patrick Mochel wrote:
> I have a (fairly large) request: 
> 
> Would you mind updating Documentation/swsusp.txt (and moving it to 
> Documentation/power/swsusp.txt)? 

Okay. I've been meaning to update it.
> 
> Frankly, the code is a mess and difficult to follow. It's also poorly
> commented. I spent the time about a month ago unwinding and deciphering 
> it. Unfortunately, my work conflicts heavily with the work that you're 
> doing, and the lack of documentation describing the intent of the code 
> makes it difficult to make sane judgements of it. 

One more problem is that you're also trying to follow a moving target
:>. In response to Pavel's last request, I'm preparing to work toward
using a linked list for the meta information (to allow unlimited image
size), and at the request of others, compressing (zlib) the saved pages
to make the image faster to save/load.

As to the layout and documentation, I hate them too. I had to keep
things as similar as possible to existing code to make merging easier,
but now that I'm merged with the 2.4 code, perhaps I can do some
cleanups.

Regards,

Nigel