Re: BUGed to death

[Dave Jones]

On Tue, Apr 15, 2003 at 10:30:24AM -0400, [e-mail] wrote:
 > The patch below eliminates 4 BUG() calls that clearly 
 > cannot happen based on the context.

This looks bogus.

 > --- linux-2.5.67-mm2/fs/reiserfs/hashes.c.orig	2003-04-15 10:11:44.000000000 -0400
 > +++ linux-2.5.67-mm2/fs/reiserfs/hashes.c	2003-04-15 10:13:43.000000000 -0400
 > @@ -90,10 +90,6 @@
 >  
 >  	if (len >= 12)
 >  	{
 > -	    	//assert(len < 16);
 > -		if (len >= 16)
 > -		    BUG();
 > -

Imagine I pass in 20. Previously, the BUG triggers. Not any more.
Ditto the other changes.  Or am _I_ missing something ?

		Dave