Re: BUGed to death

[Martin J. Bligh]

>> Seems all these bug checks are fairly expensive. I can get 1%
>> back on system time for kernel compiles by changing BUG to
>> "do {} while (0)" to make them all compile away. Profiles aren't
>> very revealing though ... seems to be within experimental error ;-(
> 
> What happens if you just turn BUG_ON into "do {} while (0)"?

I believe I already did that by turning BUG() into a null expression.

#define BUG_ON(condition) 
	do { if (unlikely((condition)!=0)) BUG(); } while(0)

The compiler should be smart enough to optimise that away, methinks.

M.