Re: Writing modules for 2.5

Dave Jones (davej@codemonkey.org.uk)
Tue, 15 Apr 2003 14:24:58 +0100


On Tue, Apr 15, 2003 at 01:57:58PM +0100, Russell King wrote:
> On Tue, Apr 15, 2003 at 02:39:14PM +0200, M?ns Rullg?rd wrote:
> > My situation is like this: I am converting a char device driver to
> > work with linux 2.5. In the open and close functions there are
> > MOD_INC/DEC_USECOUNT calls. The question is what they should be
> > replaced with. Will it be handled correctly without them?
>
> If it's a character device driver using the struct file_operations,
> set the owner field as Alan mentioned, and remove the
> MOD_{INC,DEC}_USE_COUNT macros from the open/close methods. This
> allows chrdev_open() (in fs/char_dev.c) to increment your module use
> count automatically.

Unless the open/close functions are doing funky things (like the
watchdog drivers do).

Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/