Re: [patch] dentry_stat fix

Maneesh Soni (maneesh@in.ibm.com)
Mon, 14 Apr 2003 18:09:10 +0530

On Mon, Apr 14, 2003 at 02:14:48AM -0700, Andrew Morton wrote:
> Maneesh Soni <maneesh@in.ibm.com> wrote:
> >
> > This patch the corrects the dentry_stat.nr_unused calculation.
>
> OK, I didn't even know we had a bug in there...
>
> btw, can you explain to me why shrink_dcache_anon() and select_parent() are
> putting dentries at the wrong end of dentry_unused?
prune_dcache() picks up from this end in first round. It will reset the
DCACHE_REFERENCED flag and will put it to the front of dentry_unused list.

>
> Do these dentries have DCACHE_REFERENCED set?
They will have DCACHE_REFERENCED set as they are on the unused list. The flag
get reset in the first round of aging.

> Why shouldn't they get a full two rounds of aging?
They do get.

> It is not clear what's going on in there. Thanks.

I am posting one more patch which makes the DCACHE_REFERENCED flag uses
proper following this one.

Maneesh

-- 
Maneesh Soni
IBM Linux Technology Center, 
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: maneesh@in.ibm.com
http://lse.sourceforge.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/