Re: 2.5.67-mm2

[Andrew Morton]

Alistair Strachan <[e-mail]> wrote:
>
> > EIP is at devclass_add_driver+0x34/0x8a
> ...
> 
> I get the same thing on an mm2 boot. Are you certain it isn't a -bk4 
> bug? kobject, bus_add_driver and friends have all been touched by greg 
> in bk, and I can't see anything immediately obvious in the new -mm 
> patches (-mm1 works fine).
> 
> I'll try with just the linus drop now.

It's a bk bug.  This might make it boot:

 drivers/base/class.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/base/class.c~a drivers/base/class.c
--- 25/drivers/base/class.c~a	2003-04-13 13:04:47.000000000 -0700
+++ 25-akpm/drivers/base/class.c	2003-04-13 13:04:52.000000000 -0700
@@ -105,7 +105,7 @@ int devclass_add_driver(struct device_dr
 	struct device_class * cls = get_devclass(drv->devclass);
 	int error = 0;
 
-	if (cls) {
+	if (cls && cls->subsys) {
 		down_write(&cls->subsys.rwsem);
 		pr_debug("device class %s: adding driver %s:%s\n",
 			 cls->name,drv->bus->name,drv->name);

_