Re: [PATCH] M68k IDE updates

Alan Cox (alan@lxorguk.ukuu.org.uk)
13 Apr 2003 15:10:03 +0100


On Sul, 2003-04-13 at 14:06, Geert Uytterhoeven wrote:
> +#ifdef M68K_IDE_SWAPW
> + if (M68K_IDE_SWAPW) { /* fix bus byteorder first */
> + u_char *p = (u_char *)id;
> + u_char t;
> + for (i = 0; i < 512; i += 2) {
> + t = p[i];
> + p[i] = p[i+1];
> + p[i+1] = t;
> + }
> + }
> +#endif

This looks the wrong place to fix this problem Geert. The PPC
folks have the same issues with byte order on busses but you
won't see ifdefs in the core IDE code for it.

Fix your __ide_mm_insw/ide_mm_outsw macros and the rest happens
automatically.

Linus, until better justification of why this has to be here
can you not apply this change.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/