<rant>
Well you authored the mess^H^H^H^Hwork for the suspend, and it fails the
binary logic of on or off. You failed to abort the caller for attempting
to set multiple blocks. Fix the kernel because the caller has to be
assumed dumb and brain dead ... it is user space.
</rant>
Andre Hedrick
LAD Storage Consulting Group
On Thu, 10 Apr 2003, Pavel Machek wrote:
> Hi!
>
> > > Drive->blocked is a single bit field. Its not a counting lock. Either
> > > we are blocked or not.
> >
> > Okay. We need a different solution then, but the problem remains - the
> > driver can get multiple, nexted calls to block and unblock. Can it
> > become a counting lock?
>
> Simplest fix seems to be make sure it only
> reacts to one "suspending level" (suspend_save_state)
> and that really should not be nested.
> (If that nests, fix caller)
> --
> Pavel
> Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/