Re: PATCH: Fixes for ide-disk.c

Pavel Machek (pavel@ucw.cz)
Thu, 10 Apr 2003 20:37:30 +0200


Hi!

> > Drive->blocked is a single bit field. Its not a counting lock. Either
> > we are blocked or not.
>
> Okay. We need a different solution then, but the problem remains - the
> driver can get multiple, nexted calls to block and unblock. Can it
> become a counting lock?

Simplest fix seems to be make sure it only
reacts to one "suspending level" (suspend_save_state)
and that really should not be nested.
(If that nests, fix caller)

-- 
				Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/