Re: [PATCH][2.5] xircom_cb release memory on failure

[Zwane Mwaikambo]

On Mon, 7 Apr 2003, Jeff Garzik wrote:

> regression: no longer calls leave() as intended
> 
> 
> >  
> >  	/* disable all powermanagement */
> >  	pci_write_config_dword(pdev, PCI_POWERMGMT, 0x0000);
> > @@ -250,30 +254,27 @@ static int __devinit xircom_probe(struct
> >  	   is available. 
> >  	 */
> >  	private = kmalloc(sizeof(*private),GFP_KERNEL);
> > -	memset(private, 0, sizeof(struct xircom_private));
> > +	if (private == NULL)
> > +		goto out_region;
> > +
> > +	memset(private, 0, sizeof(*private));
> 
> see davej's patches -- not needed.  get alloc_etherdev() to allocate and 
> free dev->priv, and eliminate this memset altogether.  That in turn 
> simplifies what you are trying to do here.

Hi Jeff,
	Thanks i'll fix up my mistakes and resend.

	Zwane
-- 
function.linuxpower.ca