Re: PATCH: Fixes for ide-disk.c
Nigel Cunningham (ncunningham@clear.net.nz)
Mon, 07 Apr 2003 09:58:57 +1200
On Mon, 2003-04-07 at 09:00, Alan Cox wrote:
> There are multiple "blocked" fields to deal with. drive->blocked
> indicates we can't feed it commands because it is blocked due to
> power management.
>
> idedisk_suspend sets the drive->blocked field so that we panic if
> anything is sent to the disk after we turned it off (since it
> would be a corrupter).
>
> idedisk_resume is called on the resume path and marks the drive
> as safe to use.
>
> So if you hit that bug, you did I/O after shutting the drive down,
> which is not allowed.
Okay. So the right behaviour is to ignore multiple idedisk_suspend calls
and ignore multiple idedisk_resume calls?
Regards,
Nigel
--
Nigel Cunningham
495 St Georges Road South, Hastings 4201, New Zealand
Be diligent to present yourself approved to God as a workman who does
not need to be ashamed, handling accurately the word of truth.
-- 2 Timothy 2:14, NASB.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/