Re: PATCH: Fixes for ide-disk.c

Alan Cox (alan@lxorguk.ukuu.org.uk)
06 Apr 2003 22:00:36 +0100


On Sul, 2003-04-06 at 22:12, Nigel Cunningham wrote:
> Hi again.
>
> I've just reread your message. Isn't it used as a lock at the moment?
> IIRC, you get a BUG if you try to use the driver while its blocked.
> Perhaps that's where I'm getting confused.

There are multiple "blocked" fields to deal with. drive->blocked
indicates we can't feed it commands because it is blocked due to
power management.

idedisk_suspend sets the drive->blocked field so that we panic if
anything is sent to the disk after we turned it off (since it
would be a corrupter).

idedisk_resume is called on the resume path and marks the drive
as safe to use.

So if you hit that bug, you did I/O after shutting the drive down,
which is not allowed.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/