Re: [PATCH] take 48-bit lba a bit further

[Petr Vandrovec]

On Sun, Apr 06, 2003 at 03:07:37PM +0200, Jens Axboe wrote:
> Hi,
> 
> Thanks for taking the previous bit Alan, here's an incremental update to
> 2.5.66-ac2. Just cleans up the 'when to use 48-bit lba' logic a bit per
> Andries suggestion, and also expands the request size for 48-bit lba
> capable drives to 512KiB.
> 
> Works perfectly in testing here, ext2/3 generates nice big 512KiB
> requests and the drive flies.
> 
>  	(void) probe_lba_addressing(drive, 1);
>  
> +	if (drive->addressing)
> +		blk_queue_max_sectors(&drive->queue, 1024);
> +

Should not you honor host's max queue length? siimage & pdc4030 sets
max_sectors to 128 (resp. 16 resp. 127), while you overwrite it here
unconditionally with 1024.
					Thanks,
						Petr Vandrovec
						[e-mail]