Re: [patch] acpi compile fix

Dave Jones (davej@codemonkey.org.uk)
Fri, 4 Apr 2003 21:27:44 +0100


On Fri, Apr 04, 2003 at 11:57:56AM -0800, Andrew Morton wrote:

> I think acpi_handle_t is "an opaque type specific to the OS on which the APCI
> code happens to be running".

I don't see how putting a spinlock_t cast in the code is any more
portable between OS's than spinlock_t as a function parameter.

> If the above guesses (I'd prefer not to look) are correct then
> struct acpi_handle_t {
> spinlock_t lock;
> };
>
> would make a ton more sense.

That would solve the portability argument in my eyes if that is
indeed the case here. It's still ugly, but it at least kills
the problem in a slightly more tasteful way.

Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/