Re: [PATCH] only use 48-bit lba when necessary

[John Bradford]

> > Reason is that:
> > 
> > if (expr)
> >    var = true;
> > else
> >    var = false;
> > 
> > is always a bad construct.
> >
> > var = expr;
> > 
> > is a better construct to express that meaning.
> > 
> > And yes, your is a variation of the same theme:
> > 
> > var = false;
> > if (expr)
> >    var = true;
> 
> Yes, but mine is more readable. IMO of course, that's the way it is with
> styles.

if (!expr || expr) var=(!expr ? !expr : expr);

:-)

John.