Re: [PATCH] only use 48-bit lba when necessary

[Jens Axboe]

On Fri, Apr 04 2003, Juan Quintela wrote:
> 
> Hi
> 
> jens> +	if (drive->addressing == 1 && block > 0xfffffff)
> jens> +		lba48 = 1;
> jens> +
> >> 
> >> lba48 = (drive->addressing == 1) && (block > 0xfffffff);
> >> 
> >> should do the trick.
> 
> jens> I'm not going to use such nonsense, sorry. The spelled out versions are
> jens> a lot more readable. The command ?: constructs used in ide-disk are a
> jens> joke, imo.
> 
> Read it again, please.  Told me wehre are the ?: command.

Oh, you are right. It was the one-liner style that threw me off.

> Reason is that:
> 
> if (expr)
>    var = true;
> else
>    var = false;
> 
> is always a bad construct.
>
> var = expr;
> 
> is a better construct to express that meaning.
> 
> And yes, your is a variation of the same theme:
> 
> var = false;
> if (expr)
>    var = true;

Yes, but mine is more readable. IMO of course, that's the way it is with
styles.

-- 
Jens Axboe