Re: [PATCH] reduce stack in cpqarray.c::ida_ioctl()

[Jörn Engel]

On Fri, 4 April 2003 10:09:37 +0200, Jens Axboe wrote:
> On Fri, Apr 04 2003, Jörn Engel wrote:
> > > +		error = copy_to_user(io, my_io, sizeof(*my_io)) ? -EFAULT : 0;
> > 
> > copy_to_user returns the bytes successfully copied.
> > error is set to -EFAULT, if there was actually data transferred?
> > 
> > How about:
> > +		error = copy_to_user(io, my_io, sizeof(*my_io)) < sizeof(*my_io) ? -EFAULT : 0;
> 
> Pure nonsense! Correct logic, and much nicer to read IMO is:
> 
> 	if (copy_to_user(io, my_io, sizeof(*my_io))
> 		error = -EFAULT;

Yes, you are right. I just couldn't read inline assembler properly.

Jörn

-- 
With a PC, I always felt limited by the software available. On Unix, 
I am limited only by my knowledge.
-- Peter J. Schoenster