>Yikes! Please use the actual type here instead of typeof()
>> + if (sch->lpm == 0)
>> + return -ENODEV;
>> + else
>> + return -EACCES;
>I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm
>just too picky..
Ah, don't be shy. Real men write this as
return -(sch->lpm ? EACCES : ENODEV);
:-)
Henning
-- Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/Java, perl, Solaris, Linux, xSP Consulting, Web Services freelance consultant -- Jakarta Turbine Development -- hero for hire - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/