will fix in v0004.
> The patch seems to be out of date already though. Does the new cpu speed
> code not work OK for you (for the default event value) ?
I was lagging cvs; v0003 merges to today's tree, including the new
CPU_SPEED code. posted at the url above.
> Then you should fix this generally, instead of adding the hack you do.
agree. here's a separate patch for x86+ia64. with it, there's one
extra argument to op_do_profile, and oprofile.c no longer uses op_arch.h
the architecture code directly passes eip and irq_enabled. tested on
i686 2.4.20 and ppc 2.4.20-benh.
http://bryanr.org/linux/oprofile/op_do_profile-refactor.patch
ppc v0003 depends on this change.
> > +/* TODO: fix upper level. [op_rtc_ops in ppc/ia64] is really lame. */
>
> Sure.
I'll let you handle this one.
BTW how do you feel about reworking add_sysctl and remove_sysctl to move
shared code inside oprofile.c? Right now the duplication is causing
inconsistency e.g ia64/op_pmu.c "next->mode = 0700;" vs x86/op_nmi.c
"next->mode = 0755;"
-Bryan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/