Re: sundance DFE-580TX DL10050B patch

[Philippe De Muyter]

Jeff Garzik wrote :
> On Mon, Mar 17, 2003 at 06:40:36PM +0100, Philippe De Muyter wrote:
> > Dave Jones wrote :
> > > On Mon, Mar 17, 2003 at 02:56:09PM +0100, Philippe De Muyter wrote:
> > > 
> > >  > +		writew((dev->dev_addr[i + 1] << 8) + dev->dev_addr[i],
> > > 
> > > Don't you want to OR those together instead of add them ?
> > > 
> > > 		Dave
> > > 
> > You're right.
> 
> No.
> 
> Adding and or'ing are exactly equivalent for the above case, where you
> shift an 8-bit value left 8 bits, then add it to another 8-bit value.

That was implied in Dave's remark and in my answer.

> 
> The final answer may be obtained from examining the compiler's assembly
> output, and see which combination ('or' or 'add') produces the best
> code.

We can't do that as that should be done for all the supported processors.
Furthermore, it is the compiler's job to produce the best machine code.

The only thing we can do to help the compiler is write simple code.  From
a logical point of view, oring is what is needed here, and from a hardware
point of view oring is cheaper than adding.

> 	Jeff

Now, back to the real problem :) .  Will you apply my patch ?

Philippe

Philippe De Muyter  [e-mail]  Tel [phone]
Macq Electronique SA  rue de l'Aeronef 2  B-1140 Bruxelles  Fax [phone]