Re: [Ext2-devel] [PATCH] distributed counters for ext2 to avoid group scaning

[Alex Tomas]

>>>>> Matthew Wilcox (MW) writes:

 MW> Gah.  That's your fault.  Use diff -p in future; I saw:

thanks for advice. I will.

 MW> which makes it look like the dcounters are added to ext2_bg_info.
 MW> diff -p would have put the name of the struct after the @@ line.
 MW> Not to mention you didn't follow the `s_' prefix style used
 MW> everywhere else in that struct.

this makes sense too.

 MW> Anyway, I think dcounters should probably be allocated from
 MW> kmalloc_percpu() rather than as part of the dcounter struct.

take a look.