Re: 2.5.64-mm6: oops in elv_remove_request

[Jens Axboe]

On Fri, Mar 14 2003, Jeremy Fitzhardinge wrote:
> On Fri, 2003-03-14 at 12:33, Jens Axboe wrote:
> > On Fri, Mar 14 2003, Jeremy Fitzhardinge wrote:
> > > With the version or cdrtools I compiled, I get an instant oops+lockup
> > > with the above command when running with anticipatory scheduler in
> > > 2.5.64-mm6 (hand written):
> > > 
> > > elv_remove_request
> > > ide_end_request
> > > cdrom_end_request
> > > cdrom_decode_status
> > > cdrom_newpc_intr
> > 
> > 
> > --- drivers/block/as-iosched.c~	2003-03-14 21:32:14.000000000 +0100
> > +++ drivers/block/as-iosched.c	2003-03-14 21:32:38.000000000 +0100
> > @@ -1341,6 +1341,8 @@
> >  			insert_here = ad->dispatch->prev;
> >  
> >  		list_add(&rq->queuelist, insert_here);
> > +		if (arq)
> > +			RB_CLEAR(&arq->rb_node);
> >  		
> >  		if (!list_empty(ad->dispatch) && rq_data_dir(rq) == READ
> >  			&& (ad->antic_status == ANTIC_WAIT_REQ
> 
> No joy, I'm afraid.  Same crash.

Too bad, then there are two bugs in there :/

-- 
Jens Axboe