Re: Top stack (l)users for 2.5.64-ac4

[Jens Axboe]

On Fri, Mar 14 2003, Randy.Dunlap wrote:
> On Fri, 14 Mar 2003 18:41:54 +0100 Jens Axboe <[e-mail]> wrote:
> 
> | On Fri, Mar 14 2003, Joern Engel wrote:
> | > Hi!
> | > 
> | > 47 functions using >=1k of kernel stack on i386.
> | > 
> | > One improvement over 2.5.64, i2o_proc_* is gone. 4 down, 47 to go. :)
> | > 
> | > 0xc02063f6 presto_get_fileid:                            sub    $0x1168,%esp
> | > 0xc0204fc6 presto_copy_kml_tail:                         sub    $0x101c,%esp
> | > 0xc07b92c8 isp2x00_make_portdb:                          sub    $0xc38,%esp
> | > 0xc0879c05 cdromread:                                    sub    $0xa84,%esp
> | 
> | which function is this (cdromread)?
> 
> must be drivers/cdrom/optcd.c::cdromread() (line 1601 in 2.5.64),
> due to
> 	char buf[CD_FRAMESIZE_RAWER];
> and
> #define CD_FRAMESIZE_RAWER 2646 /* The maximum possible returned bytes */ 
> in include/linux/cdrom.h.

Ahh, ok so a lot less interesting. Also why I didn't catch it here. I'd
be inclining to just making buf global there.

-- 
Jens Axboe