Re: 2.4.21pre5aa1

Andrea Arcangeli (andrea@suse.de)
Fri, 14 Mar 2003 18:35:50 +0100


On Fri, Mar 14, 2003 at 08:53:09AM -0500, Rik van Riel wrote:
> On Fri, 14 Mar 2003, Andrea Arcangeli wrote:
>
> > Only in 2.4.21pre4aa3: 9900_aio-17.gz
> > Only in 2.4.21pre5aa1: 9900_aio-18.gz
> >
> > Cleaned up the whole asm/kmap_types.h mess, moved
> > kmap_types.h into linux/, this must be visible
> > for aio and it has to be the same for all archs so it doesn't belong to
> > asm/.
>
> Maybe I'm dense, maybe it's early on a friday morning, maybe
> even both ... but I don't understand why architectures without
> highmem should have kmap_types.h

it's the aio code that does some kmap_atomic in the common code, and the
kmap_atomic pretends to get a km_type parameter. Of course the km_type
parameter is optimized away at compile time if highmem is disabled, but
this allows to use kmap_atomic in common code.

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/