Re: [2.4] Multiple memleaks in IBM Hot Plug Controller Driver

[Greg KH]

On Fri, Mar 14, 2003 at 09:34:44AM +0100, Björn Fahller wrote:
> On Thursday 13 March 2003 21.45, Oleg Drokin wrote:
> 
> Below, why allocating 2 bytes on heap (str1,) only to non-conditionally free 
> it a few lines further down? Why not keep the two bytes on stack instead? It 
> also seems like a bad idea to strncopy/strcat 1 byte long strings.

Like I previously said, this whole function is a bad dream.  Look at
what is now in 2.5, all of this nonsense is now gone.

thanks,

greg k-h