Re: [Ext2-devel] [PATCH] concurrent block allocation for ext2

[Andrew Morton]

Matthew Wilcox <[e-mail]> wrote:
>
> On Thu, Mar 13, 2003 at 09:43:05PM +0300, Alex Tomas wrote:
> > 
> > fs/attr.c:
> >         if (ia_valid & ATTR_SIZE) {
> >                 if (attr->ia_size == inode->i_size) {
> >                         if (ia_valid == ATTR_SIZE)
> >                                 goto out;       /* we can skip lock_kernel() */
> >                 } else {
> >                         lock_kernel();
> >                         error = vmtruncate(inode, attr->ia_size);
> >                         unlock_kernel();
> >                         if (error)
> >                                 goto out;
> >                 }
> >         }
> > 
> > so, all (!) truncates are serialized
> 
> This looks like a bug.  It should be safe to delete them.

Probably.  I was running without them for months.  But this is the
ftruncate() path and not the unlink() path, so I kinda forgot about it.

Most truncations are unlinks, and they are not under lock_kernel.