Re: [PATCH] add prink KERN_* suffixes

[Andreas Schwab]

Daniele Venzano <[e-mail]> writes:

|> diff -urN -X /home/venza/kernel/dontdiff linux-2.5.64/drivers/net/3c509.c linux-2.5.64-work/drivers/net/3c509.c
|> --- linux-2.5.64/drivers/net/3c509.c	2003-03-06 11:41:18.000000000 +0100
|> +++ linux-2.5.64-work/drivers/net/3c509.c	2003-03-13 12:28:39.000000000 +0100
|> @@ -316,14 +316,14 @@
|>  
|>  	{
|>  		const char *if_names[] = {"10baseT", "AUI", "undefined", "BNC"};
|> -		printk("%s: 3c5x9 at %#3.3lx, %s port, address ",
|> +		printk(KERN_INFO "%s: 3c5x9 at %#3.3lx, %s port, address ",
|>  			dev->name, dev->base_addr, if_names[(dev->if_port & 0x03)]);
|>  	}
|>  
|>  	/* Read in the station address. */
|>  	for (i = 0; i < 6; i++)
|> -		printk(" %2.2x", dev->dev_addr[i]);
|> -	printk(", IRQ %d.\n", dev->irq);
|> +		printk(KERN_INFO " %2.2x", dev->dev_addr[i]);
|> +	printk(KERN_INFO ", IRQ %d.\n", dev->irq);

This is wrong, a KERN_* prefix is only recognized after a newline.

Andreas.

-- 
Andreas Schwab, SuSE Labs, [e-mail]
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."