Re: [PATCH] bug in 2.4 bh_kmap_irq() breaks IDE under preempt patch

Jens Axboe (axboe@suse.de)
Thu, 13 Mar 2003 16:05:25 +0100


On Thu, Mar 13 2003, Joe Korty wrote:
> > I fixed this in 2.5 ages ago, just didn't get it in 2.4 block-highmem...
> > There's a tiny bit missing from your patch:
> >
> > > + local_irq_save(*flags);
> > local_irq_disable();
> >
> > other than that it's fine. See 2.5 for reference.
>
> local_irq_save() does a local_irq_disable() as part of its function.

indeed, you are right.

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/