Re: Memleak in driver for the Specialix SX series cards.

[Rogier Wolff]

On Wed, Mar 12, 2003 at 11:41:14PM +0300, Oleg Drokin wrote:
> Hello!
> 
>     I see there is a memleak in driver for the Specialix SX series cards
>     on error exit path in sx_fw_ioctl() (both in 2.4 and 2.5).
>     See the patch.
>     Found with help of smatch + unfree script.

...
> +					kfree (tmp);
>  					return -EFAULT;

Hi Oleg, 

You're right. I left it like this because "root can always mess up the
machine". But once fixed, I agree that it's better this way. 

			Roger. 

-- 
** [e-mail] ** http://www.BitWizard.nl/ ** [phone] **
*-- BitWizard writes Linux device drivers for any device you may have! --*
* The Worlds Ecosystem is a stable system. Stable systems may experience *
* excursions from the stable situation. We are currently in such an      * 
* excursion: The stable situation does not include humans. ***************