Re: Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open

[Andrew Morton]

"Martin J. Bligh" <[e-mail]> wrote:
>
> I'm getting lots of these messages whilst running big SDET runs on
> an 16-way machine ... anyone recognize them?
> (64-bk3 + a few patches).
> 
> dev (pts(136,0)) tty->count(4) != #fd's(3) in release_dev

The file_list_lock patches affect this.  Do you have those applied?

If so, and if it is repeatable, this might help.  (Unlikely, but it might).

diff -puN drivers/char/tty_io.c~tty_files-fixes drivers/char/tty_io.c
--- 25/drivers/char/tty_io.c~tty_files-fixes	2003-03-09 23:15:15.000000000 -0800
+++ 25-akpm/drivers/char/tty_io.c	2003-03-09 23:15:58.000000000 -0800
@@ -1037,7 +1037,9 @@ static void release_mem(struct tty_struc
 		}
 		o_tty->magic = 0;
 		(*o_tty->driver.refcount)--;
+		file_list_lock();
 		list_del(&o_tty->tty_files);
+		file_list_unlock();
 		free_tty_struct(o_tty);
 	}
 
@@ -1049,7 +1051,9 @@ static void release_mem(struct tty_struc
 	}
 	tty->magic = 0;
 	(*tty->driver.refcount)--;
+	file_list_lock();
 	list_del(&tty->tty_files);
+	file_list_unlock();
 	module_put(tty->driver.owner);
 	free_tty_struct(tty);
 }

_