Re: [PATCH][COMPAT] compat_sys_fcntl{,64} 1/9 Generic part

[Arnd Bergmann]

Stephen Rothwell wrote:
+asmlinkage long compat_sys_fcntl64(unsigned int fd, unsigned int cmd,
+                unsigned long arg)
+{
+        mm_segment_t old_fs;
+        struct flock f;
+        long ret;
+
+        switch (cmd) {
+        case F_GETLK:
+        case F_SETLK:
+        case F_SETLKW:
+                ret = get_compat_flock(&f, (struct compat_flock *)arg);

and

-asmlinkage long sys32_fcntl(unsigned int fd, unsigned int cmd, unsigned long arg)
-{
-       switch (cmd) {
-       case F_GETLK:
-               {
-                       struct flock f;
-                       mm_segment_t old_fs;
-                       long ret;
-                       
-                       if(get_compat_flock(&f, (struct compat_flock *)A(arg)))
                                                                   ^^^^^^^^

Did you notice the use of the address conversion macro? Maybe I missed 
something myself, but I suppose this will fail on s390 if the msb of arg 
is not cleared.

	Arnd <><