Re: [Linux-fbdev-devel] Re: FBdev updates.

[Petr Vandrovec]

On  4 Mar 03 at 22:46, Petr Vandrovec wrote:
> On Tue, Mar 04, 2003 at 10:29:06PM +0100, Jurriaan wrote:
> > > text mode.
> > 
> > There is a regression here: I boot my kernel like this:
> > 
> > kernel /boot/vmlinuz-2563matrox root=/dev/hda7 video=matrox:vesa:0x11E,fv:80,sgram hdc=scsi apm=smp apm=power-off nosmp=1
> > 
> > I see a continuous strip of alternating blocks, of sub-character size,
> > at the extreme right end of my screen. The colors seem linked to the
> > color of the line with the cursor in some way.
> > 
> > After leaving XFRee, a piece of chbg's background picture is shown for a
> > short while, then the blocks return.
> 
> Reproduced. Try this (untested) (it is against clean tree, so you'll 
> get some line offsets if you had applied my matroxfb patch). Or set 
> xres to odd value, even values do not work...
>                             Petr Vandrovec
> 
> 
> --- linux/drivers/video/console/fbcon.c 2003-03-03 18:42:37.000000000 +0100
> +++ linux/drivers/video/console/fbcon.c 2003-03-04 22:44:05.000000000 +0100
> @@ -456,7 +456,7 @@
>     region.color = attr_bgcol_ec(p, vc);
>     region.rop = ROP_COPY;
>  
> -   if (rw & !bottom_only) {
> +   if (rw && !bottom_only) {
>         region.dx = info->var.xoffset + rs;
>         region.dy = 0;
>         region.width = rw;
> -

It will not solve problem that you'll get non-black edge if your
background color is not black... I'll try to invent some solution,
like ROP_ZERO...
                                            Petr