Re: [patch] remap-file-pages-2.5.63-A0

[Linus Torvalds]

On Mon, 3 Mar 2003, Ingo Molnar wrote:
> 
> the attached patch, against BK-curr, is a preparation to make
> remap_file_pages() usable on swappable vmas as well. When 'swapping out'
> shared-named mappings the page offset is written into the pte.
> 
> it takes one bit from the swap-type bits, otherwise it does not change the
> pte layout - so it should be easy to adapt any other architecture to this
> change as well. (this patch does not introduce the protection-bits-in-pte
> approach used in my previous patch.)

One question: Why?

What's wrong with just using the value we use now (0), and just 
calculating the page from the vma/offset information? Why hide the offset 
in the page tables, when there is no need for it?

		Linus