Re: [PATCH] taskqueue to workqueue update for riscom8 driver

[Matthew Wilcox]

On Sun, Mar 02, 2003 at 05:51:01PM +0530, Amit Shah wrote:
> On Sunday 02 March 2003 10:08, Matthew Wilcox wrote:
> > No, this driver needs to be converted to the new serial core.  It's still
> > using cli(), for example.
> 
> That's a different issue, isn't it? This patch was just meant to get the 
> drivers in a compilable state... I'll look into the cli() issue, but I don't 
> have any hardware to test...

So it only compiles on UP.  Not terribly interesting.

BTW, I wouldn't necessarily expect it to work.  Work queues run in
process context; the code you replaced ran in bottom half context.
If you're going to do this kind of lame hack, it should be converted
to a tasklet, not a work queue.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk