Re: [PATCH] Multiple & vs. && and | vs. || bugs in 2.5.63

[William Lee Irwin III]

On Sun, Mar 02, 2003 at 04:19:23AM -0800, Norbert Kiesel wrote:
> --- linux-2.5.63/mm/slab.c~	2003-02-24 11:05:39.000000000 -0800
> +++ linux-2.5.63/mm/slab.c	2003-03-02 03:03:33.000000000 -0800
> @@ -1643,7 +1643,7 @@
>  	if (cachep->ctor && cachep->flags & SLAB_POISON) {
>  		unsigned long	ctor_flags = SLAB_CTOR_CONSTRUCTOR;
>  
> -		if (!flags & __GFP_WAIT)
> +		if (!(flags & __GFP_WAIT))
>  			ctor_flags |= SLAB_CTOR_ATOMIC;
>  
>  		cachep->ctor(objp, cachep, ctor_flags);

Holy cow! This is major.

akpm, please expedite.

-- wli