Re: Strange performance change 59 -> 61/62

[Martin J. Bligh]

>> Some more stats ... which look rather suspicious. 600% increase for
>> dentry_open and __mark_inode_dirty? Hmmmmm.
> 
> __mark_inode_dirty() just got itself an smp_mb().  Would be instructive to
> disable that.
> 
> dentry_open(): don't know - fs/open.c hasn't changed at all.  Perhaps
> dcache_rcu has caused additional pingpong?

2.5.59-mjb6             84 __mark_inode_dirty
2.5.61-mjb1            594 __mark_inode_dirty
2.5.61-mjb1-no_mb       74 __mark_inode_dirty

Yup, that fixed that one ... but presumably it was put there for a reason,
so I can't just rip it out ;-) Thanks, I'll go take a closer look at the
others.

M