Re: Strange TCP with 2.5.60

[Martin J. Bligh]

>> > Could you pelase retest with this patch, and tell us how many of these
>> > problems go away?
>> > 
>> > diff -puN net/ipv4/fib_hash.c~a net/ipv4/fib_hash.c
>> > --- 25/net/ipv4/fib_hash.c~a	2003-02-12 10:23:55.000000000 -0800
>> > +++ 25-akpm/net/ipv4/fib_hash.c	2003-02-12 10:24:00.000000000 -0800
>> > @@ -941,7 +941,7 @@ static __inline__ struct fib_node *fib_g
>> >  
>> >  			if (!iter->zone)
>> >  				goto out;
>> > -			if (iter->zone->fz_next)
>> > +			if (iter->zone->fz_next);
>> >  				break;
>> >  		}
>> >  		
>> > 
>> > _
>> 
>> is that patch reversed, I hope? The if doesn't do a great deal.
> 
> It is deliberate.  It directly reverts a bugfix which was recently merged.
> 
> Apparently the problem is that this combined with recent seq_file
> conversions has resulted in changed format of some /proc/net/foo files,
> which is confusing some network admin apps.
> 
> It is being worked on.

Can't we do: 

-			if (iter->zone->fz_next)
+			/* if (iter->zone->fz_next) */

or something similar? Is much less confusing ...

M.