The aic7xxx driver has one place that missed the conversion too.
Since the cmd->lun field is no longer filled in, why hasn't the
field been removed from the cmd structure? That would make it
easy to catch these kinds of bugs.
Thanks for the report. We're close to doing another aic79xx
driver drop and I'll incorporate the change then.
-- Justin > > http://linux.bkbits.net:8080/linux-2.5/diffs/drivers/scsi/aic7xxx/aic79xx_osm.c@1.16?nav=index.html|src/|src/drivers|src/drivers/scsi|src/drivers/scsi/aic7xxx|hist/drivers/scsi/aic7xxx/aic79xx_osm.c > > This change(latest aic79xx driver and scsi_cmnd changes merging) > is dropped `hscb->lun = cmd->device->lun;' (in aic79xx_osm.c line > 4272). This change cause lun detect problem. I believe it is still > needed. > > > --- linux-2.5/drivers/scsi/aic7xxx/aic79xx_osm.c.orig 2003-02-11 14:58:01.000000000 +0900 > +++ linux-2.5/drivers/scsi/aic7xxx/aic79xx_osm.c 2003-02-11 16:08:00.000000000 +0900 > @@ -1560,7 +1560,7 @@ > hscb = scb->hscb; > hscb->control = 0; > hscb->scsiid = BUILD_SCSIID(ahd, cmd); > - hscb->lun = cmd->lun; > + hscb->lun = cmd->device->lun; > hscb->cdb_len = 0; > hscb->task_management = SIU_TASKMGMT_LUN_RESET; > scb->flags |= SCB_DEVICE_RESET|SCB_RECOVERY_SCB|SCB_ACTIVE; > @@ -4269,6 +4269,7 @@ > */ > hscb->control = 0; > hscb->scsiid = BUILD_SCSIID(ahd, cmd); > + hscb->lun = cmd->device->lun; > scb->hscb->task_management = 0; > mask = SCB_GET_TARGET_MASK(ahd, scb); > > > -- > ISHIKAWA Mutsumi > <ishikawa@linux.or.jp>, <ishikawa@debian.org>, <ishikawa@netvillage.co.jp>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/