Re: [PATCH] sl82c105 driver update

[Benjamin Herrenschmidt]

On Sat, 2003-01-11 at 23:32, Russell King wrote:
> On Sat, Jan 11, 2003 at 05:33:19PM +0100, Benjamin Herrenschmidt wrote:
> > Enclosed is an update to the sl82c105 driver against 2.4.21-pre3, I'll
> > produce a 2.5 version once this is accepted by Alan.
> 
> Its still broken - if it uses DMA, the ide core will call ide_dma_on,
> which will call config_for_dma(), which will call ide_config_drive_speed,
> which will then call ide_dma_on, etc.
> 
> Sorry, I don't have a solution off hand for this.  I just wish that
> the IDE core didn't change in these incompatible ways during a stable
> kernel release.

No this problem is not here, at least not in 2.4, I did test it ;)

ide_config_drive_speed will call ide_dma_host_on, not ide_dma_on. 

Note that I think sl82c105 and ide-pmac are the only ones to redo the
DMA config on ide_dma_on. Most chipsets only do it on ide_dma_check, but
I chosed to do it in ide_dma_on too mostly because I found no way to
re-trigger ide_dma_check from hdparm (well, this might have changed
since, I have to dbl check).

Ben.