Re: Another idea for simplifying locking in kernel/module.c

[Rusty Russell]

In message <[e-mail]> you write:
> I wrote:
> >On Thu, 09 Jan 2003, Max Krasnyansky wrote:
> >>We have to be able to call try_module_get() from interrupt context.
> 
> >	Where?  Why?  Please show me one or more examples.
> 
> 	Come to think of it, I don't think you even have to answer
> that question.  You should be able to use my try_module_get() from
> interrupt context.  It never blocks.

Yes, your try_module_get just gets spurious failures on SMP, as well
as thrashing the cacheline (why bother with one counter per CPU
then?).

I guess I just don't understand your solution?

Sorry,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.